Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1422)

Issue 158970045: code review 158970045: syscall: don't cache environment variables on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by 0intro
Modified:
9 years, 5 months ago
Reviewers:
aram, gobot, bradfitz
CC:
bradfitz, rsc, aram, golang-codereviews
Visibility:
Public.

Description

syscall: don't cache environment variables on Plan 9 Fixes issue 8849.

Patch Set 1 #

Patch Set 2 : diff -r 0969b8b281efb0cfeaf89a4901db122f0f42ddd2 https://code.google.com/p/go #

Patch Set 3 : diff -r 7a5bb1f85e8dc95ee455bde7f9aee10b6b22cd53 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -82 lines) Patch
M src/syscall/env_plan9.go View 1 4 chunks +15 lines, -82 lines 0 comments Download

Messages

Total messages: 8
0intro
Hello bradfitz, rsc (cc: aram, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2014-10-15 21:03:19 UTC) #1
aram
Things like GOMAXPROCS and GODEBUG and all that are cached separately, right?
9 years, 5 months ago (2014-10-15 21:29:48 UTC) #2
0intro
> Things like GOMAXPROCS and GODEBUG and all that are > cached separately, right? The ...
9 years, 5 months ago (2014-10-16 05:47:10 UTC) #3
bradfitz
LGTM
9 years, 5 months ago (2014-10-16 08:47:56 UTC) #4
aram
LGTM Btw, rc also caches variables, though the reasons why are probably not relevant to ...
9 years, 5 months ago (2014-10-16 08:50:40 UTC) #5
0intro
> Btw, rc also caches variables, though the reasons why are probably > not relevant ...
9 years, 5 months ago (2014-10-16 08:58:38 UTC) #6
0intro
*** Submitted as https://code.google.com/p/go/source/detail?r=205fa73bb069 *** syscall: don't cache environment variables on Plan 9 Fixes issue ...
9 years, 5 months ago (2014-10-16 20:30:43 UTC) #7
gobot
9 years, 5 months ago (2014-10-19 17:00:54 UTC) #8
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-imx6 builder.
See http://build.golang.org/log/4c54c8012bb3f528a590d3cb9f03201606d2e804
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b