Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1440)

Issue 158950043: code review 158950043: database/sql: add Drivers, returning list of registered... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
gobot, bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

database/sql: add Drivers, returning list of registered drivers Fixes issue 7969.

Patch Set 1 #

Patch Set 2 : diff -r 5b0487b727a3fcb2e8262151e95664bd9bfecc28 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5b0487b727a3fcb2e8262151e95664bd9bfecc28 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 84bc9846ff7036e2b40885a51ccd819a28f0d4ad https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M src/database/sql/fakedb_test.go View 1 2 chunks +22 lines, -0 lines 0 comments Download
M src/database/sql/sql.go View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2014-10-15 03:07:38 UTC) #1
bradfitz
LGTM On Oct 15, 2014 5:07 AM, <rsc@golang.org> wrote: > Reviewers: bradfitz, > > Message: ...
9 years, 5 months ago (2014-10-15 05:33:39 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=7e241965fb8a *** database/sql: add Drivers, returning list of registered drivers Fixes issue ...
9 years, 5 months ago (2014-10-15 17:10:19 UTC) #3
gobot
9 years, 5 months ago (2014-10-15 21:28:30 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/52c158cbd5d24e27b7be3b7fe1fb402aeb4625cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b