Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(886)

Issue 158320043: code review 158320043: dashboard: update update script to delete Commit.PerfResult (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by dvyukov
Modified:
9 years, 5 months ago
Reviewers:
adg1
CC:
adg, adg1, golang-codereviews
Visibility:
Public.

Description

dashboard: update update script to delete Commit.PerfResult This is required to repair perf data in the datastore. Update issue 8930.

Patch Set 1 #

Patch Set 2 : diff -r a76f677e1aa9c193b297a96656951d59b15552a8 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r a76f677e1aa9c193b297a96656951d59b15552a8 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r a76f677e1aa9c193b297a96656951d59b15552a8 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 898a26620a353493cb70b7727b20e70893247773 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dashboard/app/build/update.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 5 months ago (2014-10-22 12:59:37 UTC) #1
dvyukov
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 5 months ago (2014-10-22 13:01:34 UTC) #2
adg1
LGTM
9 years, 5 months ago (2014-10-22 13:15:47 UTC) #3
dvyukov
9 years, 5 months ago (2014-10-22 13:44:52 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=ed46ac5bd31f&repo=tools ***

dashboard: update update script to delete Commit.PerfResult
This is required to repair perf data in the datastore.
Update issue 8930.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/158320043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b