Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 157790044: [dev.power64] code review 157790044: liblink: fix lost branch target (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by austin
Modified:
10 years, 3 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

liblink: fix lost branch target A recent commit lost the branch target in the really-big-stack case of splitstack, causing an infinite loop stack preempt case. Revive the branch target.

Patch Set 1 #

Patch Set 2 : diff -r 5b8757de02906f5959d80da00a5de1d0ba9a7d5a https://code.google.com/p/go #

Patch Set 3 : diff -r 5b8757de02906f5959d80da00a5de1d0ba9a7d5a https://code.google.com/p/go #

Patch Set 4 : diff -r f5fe58eb39f09b3d46d2d28eb89cb65a081dd719 https://code.google.com/p/go #

Patch Set 5 : diff -r f5fe58eb39f09b3d46d2d28eb89cb65a081dd719 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/liblink/obj9.c View 1 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3
austin
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
10 years, 3 months ago (2014-10-27 21:09:29 UTC) #1
rsc
LGTM
10 years, 3 months ago (2014-10-27 21:16:12 UTC) #2
austin
10 years, 3 months ago (2014-10-27 21:19:51 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=04b3ae74d8ce ***

[dev.power64] liblink: fix lost branch target

A recent commit lost the branch target in the really-big-stack
case of splitstack, causing an infinite loop stack preempt
case.  Revive the branch target.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/157790044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b