Issue 157106: x[lo:] - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157106: x[lo:] (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:
ken2

Visibility:
Public.

Description

x[lo:] - gc and runtime. * add runtime sliceslice1 for x[lo:] * remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)]. * port cgen_inline into 8g, 5g. * use native memmove in maps

Patch Set 1 #

Patch Set 2 : code review 157106: x[lo:] - gc and runtime. #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+902 lines, -144 lines)			Patch
M	src/cmd/5g/gg.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5g/ggen.c	View		2 chunks	+380 lines, -0 lines	0 comments	Download
M	src/cmd/6g/ggen.c	View		5 chunks	+56 lines, -63 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8g/gg.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View		2 chunks	+345 lines, -0 lines	0 comments	Download
M	src/cmd/gc/builtin.c.boot	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/cmd/gc/runtime.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/cmd/gc/walk.c	View		3 chunks	+36 lines, -17 lines	0 comments	Download
M	src/pkg/runtime/hashmap.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.c	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	src/pkg/runtime/slice.c	View	1	4 chunks	+44 lines, -30 lines	0 comments	Download
M	test/ken/slicearray.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	test/ken/sliceslice.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=0aaa1b156954 *** x[lo:] - gc and runtime. * add runtime sliceslice1 for ...

15 years, 4 months ago (2009-11-20 17:11:48 UTC) #1

ken2

15 years, 4 months ago (2009-11-21 20:01:17 UTC) #2

On 2009/11/20 17:11:48, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=0aaa1b156954 ***
> 
> x[lo:] - gc and runtime.
>   * add runtime sliceslice1 for x[lo:]
>   * remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)].
>   * port cgen_inline into 8g, 5g.
>   * use native memmove in maps
> 
> R=ken2
> http://codereview.appspot.com/157106

LGTM

Expand All Messages | Collapse All Messages