go: makes it build for the case $GOROOT has whitespaces

go: makes it build for the case $GOROOT has whitespaces

the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.

this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.

Fixes issue 115.

[sergio (larces), 2009-11-18 18:09:39]

Hello rsc,

this is a rather large patch, if you are brave enough heh

it's mostly changing the bash scripts and makefiles to quoted variables like
$GOROOT and $GOBIN, to support building 'go' in a directory with whitespaces. it
fixes issue 115, but needs depends on this other small patch
http://codereview.appspot.com/157066 (that getquoted() one, removing the
whitespace check)

[rsc, 2009-11-18 18:16:07]

adding dsymonds so that you can coordinate.

[dsymonds, 2009-11-18 21:06:09]

On 2009/11/18 18:16:07, rsc wrote:
> adding dsymonds so that you can coordinate.

sergio's CL looks to supercede mine, so feel free to just go with his.

[sergio (larces), 2009-11-18 21:25:37]

just remember this needs also http://codereview.appspot.com/157066/show
for handling the #pragma dynld with whitespaces in the path.

and I just noticed I forgot to remove my debugging "set -x" from Make.pkg.

sergio

[sergio (larces), 2009-11-18 22:26:53]

Updated Make.pkg, removing the debugging "set -x" option.

[rsc, 2009-11-20 05:13:07]

LGTM

Thanks.  I can't believe how terrible make is about this.

[rsc, 2009-11-23 23:56:17]

I'm having a hard time figuring out which base
you started with so that I can apply this patch.

Could you please run

 cd $GOROOT
 hg sync
 hg upload 157067

which will upload a new patch based on the current
head of the repository? 

Thanks.

[sergio (larces), 2009-11-24 01:17:40]

alright, patchset #3 is on top of current head of the repository. 

the changes from #2 are basically
i) libcgo, that is also using that ugly QUOTED_GOROOT hack in its target 

ii) it changes the Makefile of the recently added pgk/exp/exception package

[rsc, 2009-11-24 01:32:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=450c269d3885 ***

go: makes it build for the case $GOROOT has whitespaces

the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.

this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.

Fixes issue 115.

R=rsc, dsymonds1
http://codereview.appspot.com/157067

Committer: Russ Cox <rsc@golang.org>

[rsc, 2009-11-24 01:33:03]

thank you!

On Mon, Nov 23, 2009 at 17:17,  <sergio@larces.uece.br> wrote:
> alright, patchset #3 is on top of current head of the repository.
>
> the changes from #2 are basically
> i) libcgo, that is also using that ugly QUOTED_GOROOT hack in its target
>
>
> ii) it changes the Makefile of the recently added pgk/exp/exception
> package
>
> http://codereview.appspot.com/157067
>