Issue 157056: asn1: add support for RawContents

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157056: asn1: add support for RawContents (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by agl1

Modified:
15 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Patch Set 2 : code review 157056: asn1: add support for Raw_ #

Patch Set 3 : code review 157056: asn1: add support for RawContents #

Total comments: 1

Patch Set 4 : code review 157056: asn1: add support for RawContent #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1 line)			Patch
	M	src/pkg/asn1/asn1.go	View	1 2 3	5 chunks	+20 lines, -1 line	0 comments	Download
	M	src/pkg/asn1/asn1_test.go	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

I'm not a fan of the name. Can it just be "Raw" ? Or maybe ...

15 years, 4 months ago (2009-11-18 07:00:07 UTC) #2

agl1

http://codereview.appspot.com/157056/diff/1009/5 File src/pkg/asn1/asn1.go (right): http://codereview.appspot.com/157056/diff/1009/5#newcode603 src/pkg/asn1/asn1.go:603: err = StructuralError{fmt.Sprintf("tags don't match (%d vs %+v) %+v ...

15 years, 4 months ago (2009-11-18 18:55:43 UTC) #3

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=937435f09200 *** asn1: add support for RawContent R=rsc CC=golang-dev http://codereview.appspot.com/157056

15 years, 4 months ago (2009-11-19 00:32:46 UTC) #4

rsc

15 years, 4 months ago (2009-11-19 00:36:28 UTC) #5

LGTM

I see what happened - I misread the second mail
and thought you'd submitted this earlier.
Otherwise I'd have reviewed this hours ago.  Sorry.

Expand All Messages | Collapse All Messages