code review 157055: FreeBSD/i386 work

FreeBSD/i386 work

This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.

[dho, 2009-11-18 03:17:44]

Hello rsc,

I'd like you to review the following change.

[dho, 2009-11-18 03:19:31]

On 2009/11/18 03:17:44, dho wrote:
> Hello rsc,
> 
> I'd like you to review the following change.

Thanks for the tip on TLS. I got that part fixed, and now it's working
swimmingly. Hopefully there aren't any issues with code formatting. If not, this
code is in the same state as the FreeBSD/amd64 code. I'm off to bed, so I'll
talk to you tomorrow!

--dho

[rsc, 2009-11-18 07:51:31]

LGTM

Looks great.  I will make the %X -> %x change
but you will want to do the same before you
run "hg sync" or you'll get a merge conflict.

Thanks again!

http://codereview.appspot.com/157055/diff/1025/1033
File src/pkg/runtime/freebsd/386/signal.c (right):

http://codereview.appspot.com/157055/diff/1025/1033#newcode20
src/pkg/runtime/freebsd/386/signal.c:20: printf("eax     %X\n", r->sc_eax);
These should all be %x not %X.
I fixed this bug recently in the code you copied.

http://codereview.appspot.com/157055/diff/1025/1034
File src/pkg/runtime/freebsd/386/sys.s (right):

http://codereview.appspot.com/157055/diff/1025/1034#newcode95
src/pkg/runtime/freebsd/386/sys.s:95: // g = m->curg
I think the stuff from here down is missing
on the amd64 sigtramp, for what that's worth.

[rsc, 2009-11-18 07:58:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=85e5ba080170 ***

FreeBSD/i386 work

This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.

R=rsc
http://codereview.appspot.com/157055

Committer: Russ Cox <rsc@golang.org>