Issue 156210044: code review 156210044: cmd/gc: blank methods are not permitted in interface types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156210044: code review 156210044: cmd/gc: blank methods are not permitted in interface types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by cmang

Modified:
9 years, 6 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews, gri

Visibility:
Public.

Description

cmd/gc: blank methods are not permitted in interface types Fixes issue 6606.

Patch Set 2 : diff -r 9825b678db2f351718d17ce527f4b1713100243d https://code.google.com/p/go #

Patch Set 3 : diff -r 9825b678db2f351718d17ce527f4b1713100243d https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 8ad75982389b5c458a3c3c265568df912fbcde4c https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -16 lines)			Patch
M	src/cmd/gc/dcl.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/interface/explicit.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/interface/fail.go	View	1	2 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cmang

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com, gri@golang.org), I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-15 01:53:27 UTC) #1

rsc

LGTM https://codereview.appspot.com/156210044/diff/40001/src/cmd/gc/dcl.c File src/cmd/gc/dcl.c (right): https://codereview.appspot.com/156210044/diff/40001/src/cmd/gc/dcl.c#newcode562 src/cmd/gc/dcl.c:562: yyerror("methods must have a unique non-blank name"); should ...

9 years, 6 months ago (2014-10-15 02:40:07 UTC) #2

cmang

*** Submitted as https://code.google.com/p/go/source/detail?r=806a057f343b *** cmd/gc: blank methods are not permitted in interface types Fixes ...

9 years, 6 months ago (2014-10-15 16:55:28 UTC) #3

gobot

9 years, 6 months ago (2014-10-15 21:33:20 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/23302f482481de65a8d88756cf8f99ec7233bb5e

Expand All Messages | Collapse All Messages