Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(812)

Issue 156115: code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by rsc
Modified:
15 years, 4 months ago
Reviewers:
r, gri
CC:
golang-dev
Visibility:
Public.

Description

gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg

Patch Set 1 #

Patch Set 2 : code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg #

Total comments: 1

Patch Set 3 : code review 156115: gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -308 lines) Patch
M src/cmd/cgo/gcc.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/cgo/util.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ebnflint/ebnflint.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/godoc/godoc.go View 4 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/godoc/main.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/goyacc/goyacc.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/archive/tar/common.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/tar/reader.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/tar/writer_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/asn1/asn1.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/asn1/common.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/big/int.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/big/nat.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/bignum/integer.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bignum/rational.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/bufio/bufio.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/bytes/buffer.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/bytes/buffer_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/bytes/bytes.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/compress/flate/deflate.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/compress/flate/huffman_code.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/block/eax.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/block/ecb.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/crypto/block/xor.go View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/crypto/md5/md5.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/md5/md5block.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/rsa/rsa.go View 5 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/crypto/sha1/sha1.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/sha1/sha1block.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/handshake_messages.go View 9 chunks +13 lines, -13 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/tls/prf.go View 4 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/crypto/tls/record_process.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/crypto/tls/record_read.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/tls.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/debug/dwarf/buf.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/debug/dwarf/entry.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/debug/elf/file.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/debug/gosym/pclntab.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/debug/gosym/pclntab_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/debug/gosym/symtab.go View 8 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/debug/macho/file.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/ascii85/ascii85.go View 6 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/encoding/base64/base64.go View 5 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/encoding/binary/binary.go View 1 chunk +8 lines, -8 lines 0 comments Download
M src/pkg/encoding/git85/git.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/encoding/pem/pem.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/exp/4s/4s.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/datafmt/datafmt.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/datafmt/parser.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/eval/expr.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/eval/stmt.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/nacl/av/event.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/nacl/srpc/client.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/nacl/srpc/msg.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/exp/ogle/cmd.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/ogle/process.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/exp/ogle/rruntime.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/flag/flag.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/print.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/go/doc/comment.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/go/doc/doc.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/go/printer/printer.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/go/scanner/scanner.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/http/fs.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/http/request.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/url.go View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/image/png/reader.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/image/png/writer.go View 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/io/io.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/io/pipe.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/json/generic.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/json/parse.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/log/log.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/math/atan.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/sin.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/fd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/fd_darwin.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/fd_freebsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/ip.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/net/ipsock.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/parse.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/net/port.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/server_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/os/env.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/os/stat_darwin.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/stat_freebsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/stat_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/stat_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/patch/git.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/patch/patch.go View 6 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/patch/textdiff.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/path/path.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/rand/rand_test.go View 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/regexp/regexp.go View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/strconv/atoi.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/strconv/atoi_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/strconv/ftoa.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/strconv/itoa.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/strconv/quote.go View 6 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/strings/reader.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/strings/strings.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/errstr.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_linux.go View 4 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/tabwriter/tabwriter.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/format.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/template.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/testing/iotest/reader.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/testing/regexp.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/zoneinfo.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/unicode/maketables.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/utf8/utf8.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/xml/read.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/xml/xml.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 4 months ago (2009-11-20 18:23:06 UTC) #1
rsc
Easy way to see all the changes is to click on the "Download raw patch ...
15 years, 4 months ago (2009-11-20 18:29:01 UTC) #2
gri
http://codereview.appspot.com/156115/diff/1001/314 File src/pkg/math/atan.go (left): http://codereview.appspot.com/156115/diff/1001/314#oldcode35 src/pkg/math/atan.go:35: value := ((((P4*sq+P3)*sq+P2)*sq + P1) * sq + P0); ...
15 years, 4 months ago (2009-11-20 18:35:26 UTC) #3
r
LGTM
15 years, 4 months ago (2009-11-20 18:43:24 UTC) #4
rsc
15 years, 4 months ago (2009-11-20 19:45:14 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=79f9ddba20c1 ***

gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg

R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b