Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 156099: code review 156099: build Make.deps during make.bash instead (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by rsc
Modified:
15 years, 4 months ago
Reviewers:
r
Visibility:
Public.

Description

build Make.deps during make.bash instead of keeping a checked-in copy. doesn't slow down make.bash appreciably.

Patch Set 1 #

Patch Set 2 : code review 156099: build Make.deps during make.bash instead #

Patch Set 3 : code review 156099: build Make.deps during make.bash instead #

Patch Set 4 : code review 156099: build Make.deps during make.bash instead #

Total comments: 1

Patch Set 5 : code review 156099: build Make.deps during make.bash instead #

Patch Set 6 : code review 156099: build Make.deps during make.bash instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -85 lines) Patch
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M doc/contribute.html View 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/make.bash View 1 chunk +4 lines, -0 lines 0 comments Download
R src/pkg/Make.deps View 1 2 3 4 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello r, I'd like you to review the following change.
15 years, 4 months ago (2009-11-19 23:32:58 UTC) #1
r
there aren't enough pieces here. where is make.bash?
15 years, 4 months ago (2009-11-19 23:50:29 UTC) #2
rsc
Hello r, I'd like you to review the following change.
15 years, 4 months ago (2009-11-20 00:12:51 UTC) #3
r
need to update contribute.html too
15 years, 4 months ago (2009-11-20 00:14:03 UTC) #4
r
LGTM http://codereview.appspot.com/156099/diff/1008/1010 File doc/contribute.html (right): http://codereview.appspot.com/156099/diff/1008/1010#newcode108 doc/contribute.html:108: (This happens automatically each time you <code>all.bash</code> s/you/you ...
15 years, 4 months ago (2009-11-20 00:20:15 UTC) #5
rsc
15 years, 4 months ago (2009-11-20 00:27:15 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=35f71b12a3bc ***

build Make.deps during make.bash instead
of keeping a checked-in copy.  doesn't
slow down make.bash appreciably.

R=r
http://codereview.appspot.com/156099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b