Issue 156073: code review 156073: Add an intptr type to runtime; needed in FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156073: code review 156073: Add an intptr type to runtime; needed in FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by dho

Modified:
15 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

Add an intptr type to runtime; needed in FreeBSD In thread.c, we need to cast to whatever the native size of intptr is on the system, but we only have uintptr available. They're the same size, but can't do signed casts without this one :).

Patch Set 1 #

Patch Set 2 : code review 156073: Add an intptr type to runtime; needed in FreeBSD #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/runtime/freebsd/thread.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/runtime.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dho

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 4 months ago (2009-11-18 14:29:14 UTC) #1

rsc

15 years, 4 months ago (2009-11-18 17:11:42 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=392c2a73dfc2 ***

Add an intptr type to runtime; needed in FreeBSD

In thread.c, we need to cast to whatever the native
size of intptr is on the system, but we only have
uintptr available. They're the same size, but can't
do signed casts without this one :).

R=rsc
CC=golang-dev
http://codereview.appspot.com/156073

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages