Issue 156067: code review 156067: make all.bash finish on FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156067: code review 156067: make all.bash finish on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:
dho

CC:
golang-dev

Visibility:
Public.

Description

make all.bash finish on FreeBSD

Patch Set 1 #

Patch Set 2 : code review 156067: make all.bash finish on FreeBSD #

Patch Set 3 : code review 156067: make all.bash finish on FreeBSD #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	doc/progs/run	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	misc/cgo/stdio/test.bash	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello dho (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 4 months ago (2009-11-18 09:01:22 UTC) #1

dho

LGTM. I broke amd64 yesterday, but I'll open a CL for that. --dho

15 years, 4 months ago (2009-11-18 14:25:18 UTC) #2

rsc

15 years, 4 months ago (2009-11-18 17:11:21 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4a5278dd029b ***

make all.bash finish on FreeBSD

R=dho
CC=golang-dev
http://codereview.appspot.com/156067

Expand All Messages | Collapse All Messages