asn1: add Marshal.

asn1:
  * add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

[rsc, 2009-11-18 01:04:54]

LGTM

http://codereview.appspot.com/156047/diff/14/1001
File src/pkg/asn1/Makefile (right):

http://codereview.appspot.com/156047/diff/14/1001#newcode11
src/pkg/asn1/Makefile:11: serialise.go\
Sorry, american spelling please.
(I have nothing against british spelling
except that it's not the convention for
this project.)

It should probably be marshal.go anyway.

http://codereview.appspot.com/156047/diff/14/1002
File src/pkg/asn1/asn1.go (right):

http://codereview.appspot.com/156047/diff/14/1002#newcode113
src/pkg/asn1/asn1.go:113: // slice may alias the BitString.
The slice may share memory with the BitString.

http://codereview.appspot.com/156047/diff/14/1002#newcode770
src/pkg/asn1/asn1.go:770: offset, err := parseField(v, b, 0, fieldParameters{});
If there is an error should rest be nil?

http://codereview.appspot.com/156047/diff/14/1005
File src/pkg/asn1/serialise.go (right):

http://codereview.appspot.com/156047/diff/14/1005#newcode17
src/pkg/asn1/serialise.go:17: // A forkableWriter is an in-memory buffer that
can be 'forked'. Forking
--
A forkableWriter is an in-memory buffer that can be
'forked' to create new forkableWriters that bracket the
original.  After 
    pre, post := w.Fork();
the overall sequence of bytes represented is logically pre+w+post.
--

i'm pretty skeptical about this.  it's a cool idea
but it seems like a very inefficient way to do this.
it's fine for now, because it is hidden and can
be easily replaced.

http://codereview.appspot.com/156047/diff/14/1005#newcode30
src/pkg/asn1/serialise.go:30: func (f *forkableWriter) Fork() (pre, post
*forkableWriter) {
Please make the methods lowercase.
I want it to be extra clear that this is not public.

http://codereview.appspot.com/156047/diff/14/1005#newcode53
src/pkg/asn1/serialise.go:53: var nprime int;
nprimes sounds like the number of primes.

nn is more common here.

[agl1, 2009-11-18 02:06:28]

http://codereview.appspot.com/156047/diff/14/1001
File src/pkg/asn1/Makefile (right):

http://codereview.appspot.com/156047/diff/14/1001#newcode11
src/pkg/asn1/Makefile:11: serialise.go\
On 2009/11/18 01:04:54, rsc wrote:
> Sorry, american spelling please.
> (I have nothing against british spelling
> except that it's not the convention for
> this project.)
> 
> It should probably be marshal.go anyway.

Done.

http://codereview.appspot.com/156047/diff/14/1002
File src/pkg/asn1/asn1.go (right):

http://codereview.appspot.com/156047/diff/14/1002#newcode113
src/pkg/asn1/asn1.go:113: // slice may alias the BitString.
On 2009/11/18 01:04:54, rsc wrote:
> The slice may share memory with the BitString.
> 

Done.

http://codereview.appspot.com/156047/diff/14/1002#newcode770
src/pkg/asn1/asn1.go:770: offset, err := parseField(v, b, 0, fieldParameters{});
On 2009/11/18 01:04:54, rsc wrote:
> If there is an error should rest be nil?
> 

Done.

http://codereview.appspot.com/156047/diff/14/1005
File src/pkg/asn1/serialise.go (right):

http://codereview.appspot.com/156047/diff/14/1005#newcode17
src/pkg/asn1/serialise.go:17: // A forkableWriter is an in-memory buffer that
can be 'forked'. Forking
On 2009/11/18 01:04:54, rsc wrote:
> --
> A forkableWriter is an in-memory buffer that can be
> 'forked' to create new forkableWriters that bracket the
> original.  After 
>     pre, post := w.Fork();
> the overall sequence of bytes represented is logically pre+w+post.
> --
> 
> i'm pretty skeptical about this.  it's a cool idea
> but it seems like a very inefficient way to do this.
> it's fine for now, because it is hidden and can
> be easily replaced.
> 

Done.

http://codereview.appspot.com/156047/diff/14/1005#newcode30
src/pkg/asn1/serialise.go:30: func (f *forkableWriter) Fork() (pre, post
*forkableWriter) {
On 2009/11/18 01:04:54, rsc wrote:
> Please make the methods lowercase.
> I want it to be extra clear that this is not public.
> 

Done.

http://codereview.appspot.com/156047/diff/14/1005#newcode53
src/pkg/asn1/serialise.go:53: var nprime int;
On 2009/11/18 01:04:54, rsc wrote:
> nprimes sounds like the number of primes.
> 
> nn is more common here.
> 

Done.

[agl1, 2009-11-18 02:09:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=aeb5dd24d1fe ***

asn1:
  * add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

R=rsc
CC=golang-dev
http://codereview.appspot.com/156047