Issue 15550043: code review 15550043: go.net/ipv6: add missing per interface multicast listen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15550043: code review 15550043: go.net/ipv6: add missing per interface multicast listen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mikio

Modified:
11 years, 4 months ago

Reviewers:
dave

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

go.net/ipv6: add missing per interface multicast listener test

Patch Set 1 : diff -r 55437409069b https://code.google.com/p/go.net #

Total comments: 4

Patch Set 2 : diff -r 21f5e246865d https://code.google.com/p/go.net #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -8 lines)			Patch
	M	ipv6/multicastlistener_test.go	View	1	5 chunks	+54 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 5 months ago (2013-10-21 10:02:45 UTC) #1

dave_cheney.net

LGTM with minor nits, sorry it took so long to review. Test passes as root ...

11 years, 4 months ago (2013-11-02 06:36:50 UTC) #3

mikio

11 years, 4 months ago (2013-11-02 09:06:56 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=67397a11592e&repo=net ***

go.net/ipv6: add missing per interface multicast listener test

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/15550043

https://codereview.appspot.com/15550043/diff/180001/ipv6/multicastlistener_te...
File ipv6/multicastlistener_test.go (right):

https://codereview.appspot.com/15550043/diff/180001/ipv6/multicastlistener_te...
ipv6/multicastlistener_test.go:211: gaddr := &net.IPAddr{IP:
net.ParseIP("ff02::114")} // see RFC 4727
On 2013/11/02 06:36:50, dfc wrote:
> nit: gaddr := net.IPAddr{ ... }
> 
> then take the address later on as you do with ifi
> 
> this is really a small nit.

Done.

https://codereview.appspot.com/15550043/diff/180001/ipv6/multicastlistener_te...
ipv6/multicastlistener_test.go:231: defer c.Close()
On 2013/11/02 06:36:50, dfc wrote:
> is the defer sufficient to substitute for LeaveGroup on line 239 ?

yes and no, almost all cases are fine but it really depends on platform. for
example, it would be an undefined behavior if we bring down and up the interface
during this test.

Expand All Messages | Collapse All Messages