Issue 155062: gc: fix up floating point NaN comparisons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 155062: gc: fix up floating point NaN comparisons (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:
ken2

Visibility:
Public.

Description

gc: fix up floating point NaN comparisons Fixes issue 167.

Patch Set 1 #

Patch Set 2 : code review 155062: gc: fix up floating point NaN comparisons #

Patch Set 3 : code review 155062: gc: fix up floating point NaN comparisons #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -38 lines)			Patch
M	src/cmd/5g/cgen.c	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	src/cmd/6g/cgen.c	View	6 chunks	+41 lines, -14 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	5 chunks	+36 lines, -11 lines	0 comments	Download
M	src/cmd/8g/gsubr.c	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	test/float_lit.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A	test/floatcmp.go	View	1 chunk	+88 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=b6ecefde577a *** gc: fix up floating point NaN comparisons Fixes issue 167. ...

15 years, 4 months ago (2009-11-16 01:24:20 UTC) #1

ken2

15 years, 4 months ago (2009-11-16 21:05:45 UTC) #2

On 2009/11/16 01:24:20, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=b6ecefde577a ***
> 
> gc: fix up floating point NaN comparisons
> 
> Fixes issue 167.
> 
> R=ken2
> http://codereview.appspot.com/155062

LGTM

Expand All Messages | Collapse All Messages