Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19118)

Issue 154950043: code review 154950043: net: disable TestDualStackUDPListener in short mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by rsc
Modified:
9 years, 6 months ago
Reviewers:
rlh, bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

net: disable TestDualStackUDPListener in short mode This test is flaky, just like TestDualStackTCPListener. That one was disabled. Disable this one too. Update issue 5001

Patch Set 1 #

Patch Set 2 : diff -r b4f1ec3e4cc182086af8a30c19c24f0575339184 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b4f1ec3e4cc182086af8a30c19c24f0575339184 https://code.google.com/p/go/ #

Patch Set 4 : diff -r be3fe3a1120009c4d0b9b5d497b0c8d274177292 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/net/unicast_posix_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello rlh (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2014-10-06 16:06:27 UTC) #1
bradfitz
LGTM On Mon, Oct 6, 2014 at 9:06 AM, <rsc@golang.org> wrote: > Reviewers: rlh, > ...
9 years, 6 months ago (2014-10-06 16:56:44 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c83fd77ddd77 *** net: disable TestDualStackUDPListener in short mode This test is flaky, ...
9 years, 6 months ago (2014-10-06 17:09:21 UTC) #3
rlh
9 years, 6 months ago (2014-10-06 18:27:58 UTC) #4
Message was sent while issue was closed.
thanks,
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b