Issue 154870043: code review 154870043: fmt: print &map like &slice and &struct

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154870043: code review 154870043: fmt: print &map like &slice and &struct (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by r

Modified:
9 years, 6 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

fmt: print &map like &slice and &struct It was inconsistent. Also test these better. Also document the default format for types. This wasn't written down. Fixes issue 8470.

Patch Set 2 : diff -r 59dd987ff80e19e68a2dd60cee622cf453202126 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -3 lines)			Patch
M	src/fmt/doc.go	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/fmt/fmt_test.go	View		3 chunks	+32 lines, -2 lines	0 comments	Download
M	src/fmt/print.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-03 22:35:00 UTC) #1

iant

LGTM https://codereview.appspot.com/154870043/diff/1/src/fmt/doc.go File src/fmt/doc.go (right): https://codereview.appspot.com/154870043/diff/1/src/fmt/doc.go#newcode65 src/fmt/doc.go:65: array, slice: [elem0 elem1 ...} s/}/]/

9 years, 6 months ago (2014-10-04 00:23:34 UTC) #2

9 years, 6 months ago (2014-10-04 03:27:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=24c75ee81645 ***

fmt: print &map like &slice and &struct
It was inconsistent.
Also test these better.
Also document the default format for types.
This wasn't written down.

Fixes issue 8470.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/154870043

Expand All Messages | Collapse All Messages