code review 15460049: go.blog/strings: blog post about strings

go.blog/strings: blog post about strings

[r, 2013-10-22 23:06:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.blog

[kortschak, 2013-10-22 23:35:56]

https://codereview.appspot.com/15460049/diff/1/content/strings.article
File content/strings.article (right):

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcode49
content/strings.article:49: .code strings/basic.go /const string/
s/const string/const sample/

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcod...
content/strings.article:165: The output is:
Why have the output here as well as the runnable code?

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcod...
content/strings.article:273: A `for` range loop, by contrast, decodes one
UTF-8-encoded rune on each
s/range/`range`/

[r, 2013-10-22 23:51:40]

https://codereview.appspot.com/15460049/diff/1/content/strings.article
File content/strings.article (right):

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcode49
content/strings.article:49: .code strings/basic.go /const string/
On 2013/10/22 23:35:56, kortschak wrote:
> s/const string/const sample/

Done.

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcod...
content/strings.article:165: The output is:
On 2013/10/22 23:35:56, kortschak wrote:
> Why have the output here as well as the runnable code?

So you don't have to run it. Not everyone will, not everyone will be able to.

https://codereview.appspot.com/15460049/diff/1/content/strings.article#newcod...
content/strings.article:273: A `for` range loop, by contrast, decodes one
UTF-8-encoded rune on each
On 2013/10/22 23:35:56, kortschak wrote:
> s/range/`range`/

Done.

[r, 2013-10-22 23:51:41]

Hello golang-dev@googlegroups.com, dan.kortschak@adelaide.edu.au (cc:
golang-dev@googlegroups.com),

Please take another look.

[kortschak, 2013-10-23 00:00:22]

LGTM

[iant, 2013-10-23 02:51:11]

LGTM

[r, 2013-10-23 06:05:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=7b4bc047fd0e&repo=blog ***

go.blog/strings: blog post about strings

R=golang-dev, dan.kortschak, iant
CC=golang-dev
https://codereview.appspot.com/15460049

[bradfitz, 2013-10-25 15:08:01]

Unfortunately the Swedish "Place of Interest" symbol (⌘) doesn't render at
all on Chrome for Android (missing glyph from font?) and rather than simply
choose a different font for that symbol (maybe there are none available?),
it just doesn't render at all.

That makes reading this article confusing until I switched to a desktop.

Not really your problem (unless you care to change the symbol), but just
FYI.  I will make noise about this in the usual places to see why this
happens.



On Tue, Oct 22, 2013 at 4:06 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**blog <https://code.google.com/p/go.blog>
>
>
> Description:
> go.blog/strings: blog post about strings
> The date is arbitrary. TODO: Fix before submitting.
>
> Please review this at
https://codereview.appspot.**com/15460049/<https://codereview.appspot.com/154...
>
> Affected files (+435, -0 lines):
>   content/strings.article
>   content/strings/basic.go
>   content/strings/encoding.go
>   content/strings/range.go
>   content/strings/utf8.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[iant, 2013-10-25 15:13:23]

On Fri, Oct 25, 2013 at 8:08 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Unfortunately the Swedish "Place of Interest" symbol (⌘) doesn't render at
> all on Chrome for Android (missing glyph from font?) and rather than simply
> choose a different font for that symbol (maybe there are none available?),
> it just doesn't render at all.

Evidently we need to work to increase use of Android in Sweden.

Ian

[r, 2013-10-25 15:34:31]

That's ridiculous.

[bradfitz, 2013-10-25 15:39:04]

Yes.  But I think we can "fix" the problem with a line or two of webfonts
declaration, so Chrome on Android knows where to download a font if it's
missing something.



On Fri, Oct 25, 2013 at 8:34 AM, Rob Pike <r@golang.org> wrote:

> That's ridiculous.
>

[r, 2013-10-25 16:23:57]

CLs welcome. I am not familiar with the required mechanism.

[r, 2013-10-25 16:25:32]

By the way, it's nice† to see that my attempt to explain how text works has
exposed a deficiency in a text-handling program.

-rob

† For ironic definitions of nice.

[capnm, 2013-10-26 08:44:42]

On Friday, 25 October 2013 18:25:11 UTC+2, Rob Pike wrote:

> By the way, it's nice† to see that my attempt to explain how text works 
> has exposed a deficiency in a text-handling program.
>
> -rob
>
> † For ironic definitions of nice.
>

No, google just has not paid the font designer enough money to produce that 
glyph :)

~martin