Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1497)

Issue 154410043: code review 154410043: cmd/go: add '_go_' suffix to go files compiled by gccgo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by cmang
Modified:
9 years, 7 months ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/go: add '_go_' suffix to go files compiled by gccgo to avoid naming conflicts Fixes issue 8828.

Patch Set 1 #

Patch Set 2 : diff -r 8ad75982389b5c458a3c3c265568df912fbcde4c https://code.google.com/p/go #

Patch Set 3 : diff -r 8ad75982389b5c458a3c3c265568df912fbcde4c https://code.google.com/p/go #

Patch Set 4 : diff -r 8ad75982389b5c458a3c3c265568df912fbcde4c https://code.google.com/p/go #

Patch Set 5 : diff -r 8ad75982389b5c458a3c3c265568df912fbcde4c https://code.google.com/p/go #

Patch Set 6 : diff -r fb3d6c1631c3f3141f33a01afb4c0a23ef0ea2cf https://code.google.com/p/go #

Patch Set 7 : diff -r fb3d6c1631c3f3141f33a01afb4c0a23ef0ea2cf https://code.google.com/p/go #

Patch Set 8 : diff -r fb3d6c1631c3f3141f33a01afb4c0a23ef0ea2cf https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
A misc/cgo/test/issue8828.go View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A misc/cgo/test/issue8828/issue8828.c View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A misc/cgo/test/issue8828/trivial.go View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/cmd/go/build.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
cmang
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-10-15 18:29:50 UTC) #1
rsc
LGTM It should work to use just _go_.o. There is only one go output file ...
9 years, 7 months ago (2014-10-15 18:53:25 UTC) #2
cmang
On 2014/10/15 18:53:25, rsc wrote: > LGTM > > It should work to use just ...
9 years, 7 months ago (2014-10-15 19:52:33 UTC) #3
cmang
*** Submitted as https://code.google.com/p/go/source/detail?r=0969b8b281ef *** cmd/go: add '_go_' suffix to go files compiled by gccgo ...
9 years, 7 months ago (2014-10-15 20:13:42 UTC) #4
gobot
9 years, 7 months ago (2014-10-15 21:45:26 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/be695110ec1836cab1bea391eadb53d6a27fb121
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b