Issue 154350043: code review 154350043: go.image/webp: implement lossy-with-alpha.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154350043: code review 154350043: go.image/webp: implement lossy-with-alpha. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 6 months ago

Reviewers:
r, skal

CC:
r, skal, golang-codereviews

Visibility:
Public.

Description

go.image/webp: implement lossy-with-alpha. This fixes all three lossy_alpha*.webp conformance tests. The test data was generated by cwebp/dwebp version 0.4.1: cwebp yellow_rose.png -o yellow_rose.lossy-with-alpha.webp dwebp yellow_rose.lossy-with-alpha.webp -pgm -o tmp.pgm convert tmp.pgm yellow_rose.lossy-with-alpha.webp.nycbcra.png

Patch Set 1 #

Patch Set 2 : diff -r ddde472d0bf04d45c8390ed80a75a48fda6cae3e https://code.google.com/p/go.image #

Patch Set 3 : diff -r ddde472d0bf04d45c8390ed80a75a48fda6cae3e https://code.google.com/p/go.image #

Total comments: 1

Patch Set 4 : diff -r ddde472d0bf04d45c8390ed80a75a48fda6cae3e https://code.google.com/p/go.image #

Patch Set 5 : diff -r ddde472d0bf04d45c8390ed80a75a48fda6cae3e https://code.google.com/p/go.image #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+297 lines, -104 lines)			Patch
M	cmd/webp-manual-test/main.go	View	1 2 3	6 chunks	+34 lines, -7 lines	0 comments	Download
A	testdata/yellow_rose.lossy-with-alpha.webp	View	1 2 3	Binary file		0 comments	Download
A	testdata/yellow_rose.lossy-with-alpha.webp.nycbcra.png	View	1 2 3	Binary file		0 comments	Download
M	webp/decode.go	View	1	3 chunks	+138 lines, -19 lines	0 comments	Download
M	webp/decode_test.go	View	1 2 3 4	3 chunks	+125 lines, -78 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com, pascal.massimino@gmail.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-10-15 05:32:54 UTC) #1

skal

lgtm https://codereview.appspot.com/154350043/diff/40001/webp/decode.go File webp/decode.go (right): https://codereview.appspot.com/154350043/diff/40001/webp/decode.go#newcode119 webp/decode.go:119: return nil, image.Config{}, errors.New("webp: VP8X Alpha filtering != ...

9 years, 7 months ago (2014-10-15 08:51:17 UTC) #2

nigeltao

9 years, 6 months ago (2014-10-19 23:46:38 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=27ce5075ac43&repo=image ***

go.image/webp: implement lossy-with-alpha.

This fixes all three lossy_alpha*.webp conformance tests.

The test data was generated by cwebp/dwebp version 0.4.1:
cwebp yellow_rose.png -o yellow_rose.lossy-with-alpha.webp
dwebp yellow_rose.lossy-with-alpha.webp -pgm -o tmp.pgm
convert tmp.pgm yellow_rose.lossy-with-alpha.webp.nycbcra.png

LGTM=pascal.massimino, r
R=r, pascal.massimino
CC=golang-codereviews
https://codereview.appspot.com/154350043

Expand All Messages | Collapse All Messages