code review 154210044: cmd/ld: correct pe section names if longer then 8 chars

cmd/ld: correct pe section names if longer then 8 chars

gcc 4.9.1 generates pe sections with names longer then 8 charters.

From IMAGE_SECTION_HEADER definition:

Name
An 8-byte, null-padded UTF-8 string. There is no terminating null character
if the string is exactly eight characters long. For longer names, this
member contains a forward slash (/) followed by an ASCII representation
of a decimal number that is an offset into the string table.

Our current pe object file reader does not read string table when section
names starts with /. Do that, so (issue 8811 example)

c:\go\path\src\isssue8811>go build
# isssue8811
isssue8811/glfw(.text): isssue8811/glfw(/76): not defined
isssue8811/glfw(.text): undefined: isssue8811/glfw(/76)

becomes

c:\go\path\src\isssue8811>go build
# isssue8811
isssue8811/glfw(.text): isssue8811/glfw(.rdata$.refptr._glfwInitialized): not defined
isssue8811/glfw(.text): undefined: isssue8811/glfw(.rdata$.refptr._glfwInitialized)

Small progress to

Update issue 8811

[brainman, 2014-10-09 23:38:52]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2014-10-10 15:14:01]

LGTM

[jfrederich, 2014-10-10 18:22:06]

On 2014/10/09 23:38:52, brainman wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

LGTM but the same diff section is on CL 152410043

[brainman, 2014-10-11 10:20:05]

On 2014/10/10 18:22:06, jfrederich wrote:
> 
> ... but the same diff section is on CL 152410043

I will submit this CL first and remove the section from CL 152410043. I included
it as part of CL 152410043 so others could test it properly.

Alex

[brainman, 2014-10-11 10:34:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=f4cfb7885a65 ***

cmd/ld: correct pe section names if longer then 8 chars

gcc 4.9.1 generates pe sections with names longer then 8 charters.

From IMAGE_SECTION_HEADER definition:

Name
An 8-byte, null-padded UTF-8 string. There is no terminating null character
if the string is exactly eight characters long. For longer names, this
member contains a forward slash (/) followed by an ASCII representation
of a decimal number that is an offset into the string table.

Our current pe object file reader does not read string table when section
names starts with /. Do that, so (issue 8811 example)

c:\go\path\src\isssue8811>go build
# isssue8811
isssue8811/glfw(.text): isssue8811/glfw(/76): not defined
isssue8811/glfw(.text): undefined: isssue8811/glfw(/76)

becomes

c:\go\path\src\isssue8811>go build
# isssue8811
isssue8811/glfw(.text): isssue8811/glfw(.rdata$.refptr._glfwInitialized): not
defined
isssue8811/glfw(.text): undefined:
isssue8811/glfw(.rdata$.refptr._glfwInitialized)

Small progress to

Update issue 8811

LGTM=iant, jfrederich
R=golang-codereviews, iant, jfrederich
CC=golang-codereviews
https://codereview.appspot.com/154210044

[gobot, 2014-10-13 03:30:41]

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/f7785d968d1325994b8d3897618e89d6295f0f2c