Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(849)

Issue 154180043: code review 154180043: undo CL 145150043 / 8b3d26697b8d (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by brainman
Modified:
10 years, 5 months ago
Reviewers:
gobot
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

undo CL 145150043 / 8b3d26697b8d That was complete failure - builders are broken, but original cl worked fine on my system. I will need access to builders to test this change properly. ««« original CL description runtime: handle all windows exception Fixes issue 8006. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://codereview.appspot.com/145150043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 8b3d26697b8db9c738fbd96ee381e69ab92cffe0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8b3d26697b8db9c738fbd96ee381e69ab92cffe0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -220 lines) Patch
M src/runtime/defs_windows.go View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/defs_windows_386.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/defs_windows_amd64.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/os_windows.c View 1 6 chunks +6 lines, -29 lines 0 comments Download
M src/runtime/os_windows_386.c View 1 2 chunks +31 lines, -49 lines 0 comments Download
M src/runtime/os_windows_amd64.c View 1 2 chunks +31 lines, -62 lines 0 comments Download
M src/runtime/sys_windows_386.s View 1 4 chunks +2 lines, -16 lines 0 comments Download
M src/runtime/sys_windows_amd64.s View 1 4 chunks +2 lines, -16 lines 0 comments Download
M src/runtime/syscall_windows_test.go View 1 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 3
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 5 months ago (2014-10-09 06:22:53 UTC) #1
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=22318cd31d7d *** undo CL 145150043 / 8b3d26697b8d That was complete failure - ...
10 years, 5 months ago (2014-10-09 06:24:42 UTC) #2
gobot
10 years, 5 months ago (2014-10-09 07:32:12 UTC) #3
Message was sent while issue was closed.
This changed caused perf changes on windows-amd64-perf:


json-1                    old          new      delta
cputime             184687500    178750000      -3.21
time                184926752    178901308      -3.26

json-2                    old          new      delta
cputime             187343750    180625000      -3.59
time                 93904671     91142184      -2.94

json-4                    old          new      delta
cputime             189296875    180937500      -4.42
time                 47898190     46321768      -3.29

json-8                    old          new      delta
time                 25392896     24746313      -2.55

http://build.golang.org/perfdetail?commit=22318cd31d7db4530bbc1332afabb44ea7a...



—gobot
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b