Issue 154144: gc: two bug fixes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154144: gc: two bug fixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:
ken2

Visibility:
Public.

Description

gc: five bug fixes, one better error. * check for struct literal assignment to private fields. * record, fix crash involving parallel map assignment. * avoid infinite recursion in exportassignok. * make floating point bounds check precise. * avoid crash on invalid receiver. * add context to error about implicit assignment. Fixes issue 86. Fixes issue 88. Fixes issue 158. Fixes issue 174. Fixes issue 201. Fixes issue 204.

Patch Set 1 #

Patch Set 2 : code review 154144: gc: five bug fixes, one better error. #

Patch Set 3 : code review 154144: gc: five bug fixes, one better error. #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -65 lines)			Patch
M	src/cmd/gc/align.c	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/cmd/gc/const.c	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View		1 chunk	+17 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.y	View		2 chunks	+13 lines, -2 lines	0 comments	Download
M	src/cmd/gc/obj.c	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/cmd/gc/range.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/sinit.c	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	24 chunks	+72 lines, -43 lines	0 comments	Download
M	src/cmd/gc/walk.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/lib.c	View	2	2 chunks	+14 lines, -5 lines	0 comments	Download
M	src/pkg/math/all_test.go	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	test/assign.go	View		2 chunks	+9 lines, -1 line	0 comments	Download
A	test/fixedbugs/bug214.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug215.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug216.go	View	2	1 chunk	+20 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug217.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=7e66bbd556da *** gc: five bug fixes, one better error. * check for ...

15 years, 4 months ago (2009-11-15 20:57:11 UTC) #1

ken2

15 years, 4 months ago (2009-11-15 23:14:38 UTC) #2

On 2009/11/15 20:57:11, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=7e66bbd556da ***
> 
> gc: five bug fixes, one better error.
> 
> * check for struct literal assignment to private fields.
> * record, fix crash involving parallel map assignment.
> * avoid infinite recursion in exportassignok.
> * make floating point bounds check precise.
> * avoid crash on invalid receiver.
> 
> * add context to error about implicit assignment.
> 
> Fixes issue 86.
> Fixes issue 88.
> Fixes issue 158.
> Fixes issue 174.
> Fixes issue 201.
> Fixes issue 204.
> 
> R=ken2
> http://codereview.appspot.com/154144

LGTM

Expand All Messages | Collapse All Messages