Issue 154073: code review 154073: - s/Element/interface{}/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154073: code review 154073: - s/Element/interface{}/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by gri

Modified:
15 years, 5 months ago

Reviewers:
rsc

Visibility:
Public.

Description

vector: s/Element/interface{}/ Fixes issue 74.

Patch Set 1 #

Patch Set 2 : code review 154073: vector: s/Element/interface{}/ #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -24 lines)			Patch
	M	src/pkg/container/vector/vector.go	View		11 chunks	+18 lines, -23 lines	0 comments	Download
	M	src/pkg/container/vector/vector_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

LGTM A few nits on the description: the first line of the description will be ...

15 years, 5 months ago (2009-11-12 01:24:07 UTC) #2

gri

15 years, 5 months ago (2009-11-12 01:25:52 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=423c95c8f2c8 ***

vector: s/Element/interface{}/
Fixes issue 74.

R=rsc
http://codereview.appspot.com/154073

Expand All Messages | Collapse All Messages