Issue 154020043: code review 154020043: os, syscall: test Chtimes on directories, fix on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154020043: code review 154020043: os, syscall: test Chtimes on directories, fix on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
gobot, brainman

CC:
brainman, golang-codereviews

Visibility:
Public.

Description

os, syscall: test Chtimes on directories, fix on Windows Fixes issue 8090.

Patch Set 2 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Patch Set 3 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 09a7810062330d50387b1968821f41fc51bac2e6 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
	M	src/os/os_test.go	View	1 2 3	2 chunks	+38 lines, -9 lines	0 comments	Download
	M	src/syscall/syscall_windows.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello brainman (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-06 19:31:49 UTC) #1

brainman

LGTM https://codereview.appspot.com/154020043/diff/40001/src/os/os_test.go File src/os/os_test.go (right): https://codereview.appspot.com/154020043/diff/40001/src/os/os_test.go#newcode787 src/os/os_test.go:787: func TestChtimesDir(t *testing.T) { Add comment similar to ...

9 years, 6 months ago (2014-10-06 22:55:08 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=6e6d0cf0a105 *** os, syscall: test Chtimes on directories, fix on Windows Fixes ...

9 years, 6 months ago (2014-10-06 23:22:54 UTC) #3

gobot

9 years, 6 months ago (2014-10-07 00:50:13 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-386-387 builder.
See http://build.golang.org/log/d9336117dc8f5112e219716ffb32b20f5bcf41dc

Expand All Messages | Collapse All Messages