Issue 153860043: code review 153860043: go.net/ipv4: restructure ancillary data socket option h...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153860043: code review 153860043: go.net/ipv4: restructure ancillary data socket option h... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by mikio

Modified:
9 years, 6 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

go.net/ipv4: restructure ancillary data socket option handling This CL chops existing ancillary data socket option handlers and puts them into platform dependent ancillary data socket option binding table for code readability. Fixes issue 6710.

Patch Set 1 : diff -r 2084e7244573c75d309c7e9da701504d5e0dcb95 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 2084e7244573c75d309c7e9da701504d5e0dcb95 https://code.google.com/p/go.net #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -257 lines)			Patch
M	ipv4/control.go	View	2 chunks	+19 lines, -1 line	0 comments	Download
M	ipv4/control_bsd.go	View	1 chunk	+17 lines, -121 lines	0 comments	Download
R	ipv4/control_linux.go	View	1 chunk	+0 lines, -84 lines	0 comments	Download
R	ipv4/control_nonpktinfo.go	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	ipv4/control_pktinfo.go	View	1 chunk	+15 lines, -10 lines	0 comments	Download
M	ipv4/control_unix.go	View	3 chunks	+125 lines, -4 lines	0 comments	Download
M	ipv4/sys_bsd.go	View	1 chunk	+11 lines, -12 lines	0 comments	Download
M	ipv4/sys_darwin.go	View	2 chunks	+14 lines, -1 line	0 comments	Download
M	ipv4/sys_freebsd.go	View	1 chunk	+10 lines, -13 lines	0 comments	Download
M	ipv4/sys_linux.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ipv4/sys_stub.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ipv4/sys_windows.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 6 months ago (2014-10-03 23:29:09 UTC) #1

mikio

9 years, 6 months ago (2014-10-04 00:51:20 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=a35a4571eb78&repo=net ***

go.net/ipv4: restructure ancillary data socket option handling

This CL chops existing ancillary data socket option handlers and
puts them into platform dependent ancillary data socket option
binding table for code readability.

Fixes issue 6710.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/153860043

Expand All Messages | Collapse All Messages