code review 15380044: net/mail: correctly handle whitespaces when formatting an email address

net/mail: correctly handle whitespaces when formatting an email address

Whitespace characters are allowed in quoted-string according to RFC 5322 without being "Q"-encoding. Address.String() already always formats the name portion in quoted string, so whitespace characters should be allowed in there.

[rich, 2013-10-21 03:00:00]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rich, 2013-10-21 03:10:46]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2013-10-21 05:40:53]

NOT LGTM

ASCII space (0x20) is *not* printable (it's a space; what would you print?). It
is also not included in the qtext/vchar sets as defined in RFC 5322.

[rich, 2013-10-21 13:14:07]

On 2013/10/21 05:40:53, dsymonds wrote:
> NOT LGTM
> 
> ASCII space (0x20) is *not* printable (it's a space; what would you print?).
It
> is also not included in the qtext/vchar sets as defined in RFC 5322.

Since we are putting the content in double quotes anyways, we really care about
quoted-string as defined in RFC 5322 which allows FWS in addition to qtext
   qtext           =   %d33 /             ; Printable US-ASCII
                       %d35-91 /          ;  characters not including
                       %d93-126 /         ;  "\" or the quote character
                       obs-qtext

   qcontent        =   qtext / quoted-pair

   quoted-string   =   [CFWS]
                       DQUOTE *([FWS] qcontent) [FWS] DQUOTE
                       [CFWS]


Doesn't it seem to make more sense to have mail address be formatted as

"First Last" <foo@bar.org>

instead of

=?utf-8?q?First_Last?= <foo@bar.org>

?

[dsymonds, 2013-10-22 03:04:36]

The solution then is not to change qtext, but change the formatter to
aim for quoted-string.

But we're too close to Go 1.2 for this change; please file a bug on
the issue tracker and ping us after Go 1.2 is out the door. Thanks.

[gobot, 2013-12-20 16:26:06]

Replacing golang-dev with golang-codereviews.

[dsymonds, 2014-01-03 00:44:11]

R=close

This seems to have been abandoned. If you want to pursue this, file an issue
like I suggested.

[rich, 2014-01-03 00:47:01]

On 2014/01/03 00:44:11, dsymonds wrote:
> R=close
> 
> This seems to have been abandoned. If you want to pursue this, file an issue
> like I suggested.

The issue was filed on Oct 22 like you suggested.
https://code.google.com/p/go/issues/detail?id=6641

[dsymonds, 2014-01-03 00:47:45]

Sorry, didn't see that. Thanks.