Issue 153770043: code review 153770043: encoding/asn1: fix unmarshaling of implicitly tagged UT...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153770043: code review 153770043: encoding/asn1: fix unmarshaling of implicitly tagged UT... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by agl1

Modified:
9 years, 7 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

encoding/asn1: fix unmarshaling of implicitly tagged UTF-8 strings. Fixes issue 8541.

Patch Set 1 #

Patch Set 2 : diff -r 2080ff7fb64eef97158d02dbfb77ecd96f872629 https://code.google.com/p/go #

Patch Set 3 : diff -r 4c137c3e43482319c595f6b69582157208deeaf5 https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	src/encoding/asn1/asn1.go	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
	M	src/encoding/asn1/asn1_test.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-09-30 18:49:13 UTC) #3

agl1

9 years, 7 months ago (2014-09-30 18:49:22 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=b0e301357101 ***

encoding/asn1: fix unmarshaling of implicitly tagged UTF-8 strings.

Fixes issue 8541.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/153770043

Expand All Messages | Collapse All Messages