code review 153750044: cmd/objdump: move armasm, x86asm into internal packages

cmd/objdump: move armasm, x86asm into internal packages

For Go 1.3 these external packages were collapsed into
large single-file implementations stored in the cmd/objdump
directory.

For Go 1.4 we want pprof to be able to link against them too,
so move them into cmd/internal, where they can be shared.

The new files are copied from the repo in the file path (rsc.io/...).
Those repos were code reviewed during development
(mainly by crawshaw and minux), because we knew the
main repo would use them.

Update issue 8798

[rsc, 2014-09-30 15:50:40]

Hello crawshaw (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-09-30 15:53:50]

LGTM


On Tue, Sep 30, 2014 at 8:50 AM, <rsc@golang.org> wrote:

> Reviewers: crawshaw,
>
> Message:
> Hello crawshaw (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/objdump: move armasm, x86asm into internal packages
>
> For Go 1.3 these external packages were collapsed into
> large single-file implementations stored in the cmd/objdump
> directory.
>
> For Go 1.4 we want pprof to be able to link against them too,
> so move them into cmd/internal, where they can be shared.
>
> The new files are copied from the repo in the file path (rsc.io/...).
> Those repos were code reviewed during development
> (mainly by crawshaw and minux), because we knew the
> main repo would use them.
>
> Update issue 8798
>
> Please review this at https://codereview.appspot.com/153750044/
>
> Affected files (+35092, -24625 lines):
>   A src/cmd/internal/rsc.io/arm/armasm/Makefile
>   A src/cmd/internal/rsc.io/arm/armasm/decode.go
>   A src/cmd/internal/rsc.io/arm/armasm/decode_test.go
>   A src/cmd/internal/rsc.io/arm/armasm/ext_test.go
>   A src/cmd/internal/rsc.io/arm/armasm/gnu.go
>   A src/cmd/internal/rsc.io/arm/armasm/inst.go
>   A src/cmd/internal/rsc.io/arm/armasm/objdump_test.go
>   A src/cmd/internal/rsc.io/arm/armasm/objdumpext_test.go
>   A src/cmd/internal/rsc.io/arm/armasm/plan9x.go
>   A src/cmd/internal/rsc.io/arm/armasm/tables.go
>   A src/cmd/internal/rsc.io/arm/armasm/testdata/Makefile
>   A src/cmd/internal/rsc.io/arm/armasm/testdata/decode.txt
>   A src/cmd/internal/rsc.io/x86/x86asm/Makefile
>   A src/cmd/internal/rsc.io/x86/x86asm/decode.go
>   A src/cmd/internal/rsc.io/x86/x86asm/decode_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/ext_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/gnu.go
>   A src/cmd/internal/rsc.io/x86/x86asm/inst.go
>   A src/cmd/internal/rsc.io/x86/x86asm/inst_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/intel.go
>   A src/cmd/internal/rsc.io/x86/x86asm/objdump_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/objdumpext_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/plan9ext_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/plan9x.go
>   A src/cmd/internal/rsc.io/x86/x86asm/plan9x_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/tables.go
>   A src/cmd/internal/rsc.io/x86/x86asm/testdata/Makefile
>   A src/cmd/internal/rsc.io/x86/x86asm/testdata/decode.txt
>   A src/cmd/internal/rsc.io/x86/x86asm/xed_test.go
>   A src/cmd/internal/rsc.io/x86/x86asm/xedext_test.go
>   R src/cmd/objdump/armasm.go
>   M src/cmd/objdump/main.go
>   R src/cmd/objdump/x86.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-09-30 16:28:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=4d7888400e99 ***

cmd/objdump: move armasm, x86asm into internal packages

For Go 1.3 these external packages were collapsed into
large single-file implementations stored in the cmd/objdump
directory.

For Go 1.4 we want pprof to be able to link against them too,
so move them into cmd/internal, where they can be shared.

The new files are copied from the repo in the file path (rsc.io/...).
Those repos were code reviewed during development
(mainly by crawshaw and minux), because we knew the
main repo would use them.

Update issue 8798

LGTM=bradfitz
R=crawshaw, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/153750044