Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(446)

Issue 153720043: code review 153720043: [release-branch.go1.3] time: removed from tests now obs... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by adg
Modified:
9 years, 6 months ago
Reviewers:
dsymonds
CC:
rsc, dsymonds, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] time: removed from tests now obsolete assumption about Australian tz abbreviations ««« CL 130920043 / 7dba9475ee72 time: removed from tests now obsolete assumption about Australian tz abbreviations Australian timezones abbreviation for standard and daylight saving time were recently changed from EST for both to AEST and AEDT in the icann tz database (see changelog on www.iana.org/time-zones). A test in the time package was written to check that the ParseInLocation function understand that Feb EST and Aug EST are different time zones, even though they are both called EST. This is no longer the case, and the Date function now returns AEST or AEDT for australian tz on every Linux system with an up to date tz database (and this makes the test fail). Since I wasn't able to find another country that 1) uses daylight saving and 2) has the same abbreviation for both on tzdata, I changed the test to make sure that ParseInLocation does not get confused when it parses, in different locations, two dates with the same abbreviation (this was suggested in the mailing list). Fixes issue 8547. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/130920043 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 85518b1d6f8d6e16133b9ed2c9db6807522d37de https://code.google.com/p/go #

Patch Set 3 : diff -r 85518b1d6f8d6e16133b9ed2c9db6807522d37de https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M src/pkg/time/format_test.go View 1 1 chunk +21 lines, -15 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-09-29 03:38:49 UTC) #1
dsymonds
LGTM
9 years, 6 months ago (2014-09-29 03:45:29 UTC) #2
adg
9 years, 6 months ago (2014-09-29 03:46:23 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=e11f3e56a8bf ***

[release-branch.go1.3] time: removed from tests now obsolete assumption about
Australian tz abbreviations

««« CL 130920043 / 7dba9475ee72
time: removed from tests now obsolete assumption about Australian tz
abbreviations

Australian timezones abbreviation for standard and daylight saving time were
recently
changed from EST for both to AEST and AEDT in the icann tz database (see
changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation
function
understand that Feb EST and Aug EST are different time zones, even though they
are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz
database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2)
has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations,
two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes issue 8547.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/130920043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»

LGTM=dsymonds
R=rsc, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/153720043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b