code review 153710043: runtime/pprof: disable new memory test

runtime/pprof: disable new memory test

It cannot run 'go tool pprof'. There is no guarantee that's installed.
It needs to build a temporary pprof binary and run that.
It also needs to skip the test on systems that can't build and
run binaries, namely android and nacl.

See src/cmd/nm/nm_test.go's TestNM for a template.

Update issue 8867
Status: Accepted

[rsc, 2014-10-16 18:58:07]

Hello dvyukov (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-10-16 18:58:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=7a5bb1f85e8d ***

runtime/pprof: disable new memory test

It cannot run 'go tool pprof'. There is no guarantee that's installed.
It needs to build a temporary pprof binary and run that.
It also needs to skip the test on systems that can't build and
run binaries, namely android and nacl.

See src/cmd/nm/nm_test.go's TestNM for a template.

Update issue 8867
Status: Accepted

TBR=dvyukov
CC=golang-codereviews
https://codereview.appspot.com/153710043

[brainman, 2014-10-16 22:30:40]

https://codereview.appspot.com/153710043/diff/20002/src/runtime/malloc.go
File src/runtime/malloc.go (right):

https://codereview.appspot.com/153710043/diff/20002/src/runtime/malloc.go#new...
src/runtime/malloc.go:43: //go:nowritebarrier
What is this to do with "disable new memory test" CL?

[rsc, 2014-10-16 23:50:26]

https://codereview.appspot.com/153710043/diff/20002/src/runtime/malloc.go
File src/runtime/malloc.go (right):

https://codereview.appspot.com/153710043/diff/20002/src/runtime/malloc.go#new...
src/runtime/malloc.go:43: //go:nowritebarrier
On 2014/10/16 22:30:39, brainman wrote:
> What is this to do with "disable new memory test" CL?

thanks. that wasn't supposed to be there. it doesn't even do anything.

[gobot, 2014-10-17 04:01:20]

This CL appears to have broken the linux-arm-luitvd builder.
See http://build.golang.org/log/d1cefce282345d0d7939e0695e30c4cb6f1130dd