LGTM but rename to reqmu also? On Mon, Oct 13, 2014 at 6:45 PM, <r@golang.org> ...
9 years, 6 months ago
(2014-10-13 16:48:42 UTC)
#2
LGTM but rename to reqmu also?
On Mon, Oct 13, 2014 at 6:45 PM, <r@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net/rpc: fix mutex comment
> Fixes issue 8086.
>
> Please review this at https://codereview.appspot.com/153420044/
>
> Affected files (+2, -2 lines):
> M src/net/rpc/client.go
>
>
> Index: src/net/rpc/client.go
> ===================================================================
> --- a/src/net/rpc/client.go
> +++ b/src/net/rpc/client.go
> @@ -41,10 +41,10 @@
> type Client struct {
> codec ClientCodec
>
> - sending sync.Mutex
> + sending sync.Mutex // protects following
> + request Request
>
> mutex sync.Mutex // protects following
> - request Request
> seq uint64
> pending map[uint64]*Call
> closing bool // user has called Close
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Issue 153420044: code review 153420044: net/rpc: fix mutex comment
(Closed)
Created 9 years, 6 months ago by r
Modified 9 years, 6 months ago
Reviewers:
Base URL:
Comments: 0