Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13620)

Issue 15330043: code review 15330043: cmd/yacc: fix stderr on Windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by minux1
Modified:
10 years, 6 months ago
Reviewers:
r, dfc
CC:
golang-dev, dfc, r
Visibility:
Public.

Description

cmd/yacc: fix stderr on Windows. Fixes issue 6620.

Patch Set 1 #

Patch Set 2 : diff -r b508daf6dae6 https://code.google.com/p/go #

Patch Set 3 : diff -r b508daf6dae6 https://code.google.com/p/go #

Patch Set 4 : diff -r b508daf6dae6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/yacc/yacc.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2013-10-20 01:08:24 UTC) #1
dfc
LGTM. Thanks. Not sure if you need to wait for adg, rsc or Ian. > ...
10 years, 6 months ago (2013-10-20 01:37:38 UTC) #2
minux1
On Sat, Oct 19, 2013 at 9:37 PM, Dave Cheney <dave@cheney.net> wrote: > Not sure ...
10 years, 6 months ago (2013-10-20 01:53:00 UTC) #3
r
LGTM
10 years, 6 months ago (2013-10-20 02:53:04 UTC) #4
minux1
10 years, 6 months ago (2013-10-20 03:07:27 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=69bf31787310 ***

cmd/yacc: fix stderr on Windows.
Fixes issue 6620.

R=golang-dev, dave, r
CC=golang-dev
https://codereview.appspot.com/15330043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b