Issue 152970043: code review 152970043: misc/cgo/test: fail issue 7978 with clearer error when ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152970043: code review 152970043: misc/cgo/test: fail issue 7978 with clearer error when ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
iant

CC:
golang-codereviews, iant, r

Visibility:
Public.

Description

misc/cgo/test: fail issue 7978 with clearer error when GOTRACEBACK != 2 The test doesn't work with GOTRACEBACK != 2. Diagnose that failure mode.

Patch Set 2 : diff -r 1a6aa1230701397d08732d68ec13c9201b5dfb8f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1a6aa1230701397d08732d68ec13c9201b5dfb8f https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r bc0fe81c7252a5597bbc02c82f6a09f649c3e91e https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	misc/cgo/test/issue7978.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-03 20:28:13 UTC) #1

iant

https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go File misc/cgo/test/issue7978.go (right): https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go#newcode86 misc/cgo/test/issue7978.go:86: t.Fatalf("GOTRACEBACK must be 2") How about t.Skip?

9 years, 6 months ago (2014-10-03 20:29:52 UTC) #2

rsc

9 years, 6 months ago (2014-10-03 20:31:16 UTC) #3

rsc

9 years, 6 months ago (2014-10-03 20:42:20 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b4f1ec3e4cc1 ***

misc/cgo/test: fail issue 7978 with clearer error when GOTRACEBACK != 2

The test doesn't work with GOTRACEBACK != 2.
Diagnose that failure mode.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://codereview.appspot.com/152970043

Expand All Messages | Collapse All Messages