Issue 152860043: code review 152860043: driver: fix bad pointer on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152860043: code review 152860043: driver: fix bad pointer on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by dvyukov

Modified:
9 years, 6 months ago

Reviewers:
brainman, DMorsing

CC:
brainman, DMorsing, golang-codereviews

Visibility:
Public.

Description

driver: fix bad pointer on windows Fixes issue 8848.

Patch Set 2 : diff -r 17ba038321240785d36e5d29dcddb825a75d9c19 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r 17ba038321240785d36e5d29dcddb825a75d9c19 https://code.google.com/p/go.benchmarks #

Total comments: 1

Patch Set 4 : diff -r 17ba038321240785d36e5d29dcddb825a75d9c19 https://code.google.com/p/go.benchmarks #

Patch Set 5 : diff -r 17ba038321240785d36e5d29dcddb825a75d9c19 https://code.google.com/p/go.benchmarks #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	driver/driver_windows.go	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello alex.brainman@gmail.com, daniel.morsing@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks

9 years, 6 months ago (2014-10-03 08:57:53 UTC) #1

brainman

LGTM Thank you. Alex https://codereview.appspot.com/152860043/diff/40001/driver/driver_windows.go File driver/driver_windows.go (right): https://codereview.appspot.com/152860043/diff/40001/driver/driver_windows.go#newcode97 driver/driver_windows.go:97: var o uintptr Please put ...

9 years, 6 months ago (2014-10-03 09:59:00 UTC) #3

dvyukov

On 2014/10/03 09:59:00, brainman wrote: > LGTM > > Thank you. > > Alex > ...

9 years, 6 months ago (2014-10-03 11:24:20 UTC) #4

dvyukov

9 years, 6 months ago (2014-10-03 11:24:38 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=c1aee9f08d22&repo=benchmarks ***

driver: fix bad pointer on windows
Fixes issue 8848.

LGTM=daniel.morsing, alex.brainman
R=alex.brainman, daniel.morsing
CC=golang-codereviews
https://codereview.appspot.com/152860043

Expand All Messages | Collapse All Messages