Issue 152760043: code review 152760043: [release-branch.go1.3] runtime: fix GOTRACEBACK reading...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152760043: code review 152760043: [release-branch.go1.3] runtime: fix GOTRACEBACK reading... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
gobot, adg, brainman

CC:
golang-codereviews, adg, brainman, iant, r

Visibility:
Public.

Description

[release-branch.go1.3] runtime: fix GOTRACEBACK reading on Windows, Plan 9 Only Unix was resetting the traceback_cache variable after initializing the environment. Reset it on all systems by resetting in parsedebugvars. Fixes issue 8813.

Patch Set 1 #

Patch Set 2 : diff -r f1046f988c1a https://code.google.com/p/go/ #

Patch Set 3 : diff -r f1046f988c1a https://code.google.com/p/go/ #

Patch Set 4 : diff -r f1046f988c1a https://code.google.com/p/go/ #

Patch Set 5 : diff -r f1046f988c1a https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/pkg/runtime/runtime.c	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: adg, brainman, iant, r), I'd like you to review this change to ...

9 years, 6 months ago (2014-09-30 02:31:03 UTC) #1

brainman

LGTM You didn't need the comment. Only windows is broken. plan9 just read environment every ...

9 years, 6 months ago (2014-09-30 02:34:39 UTC) #3

rsc

I will leave the comment for the poor souls who end up needing work on ...

9 years, 6 months ago (2014-09-30 02:50:20 UTC) #4

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=6ee8ec277a21 *** [release-branch.go1.3] runtime: fix GOTRACEBACK reading on Windows, Plan 9 Only ...

9 years, 6 months ago (2014-09-30 02:50:42 UTC) #5

gobot

9 years, 6 months ago (2014-09-30 02:58:28 UTC) #6

Message was sent while issue was closed.

This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/6d7fc4304847d0cd21d6ba0b1526470bbb35a1c8

Expand All Messages | Collapse All Messages