Issue 152580043: code review 152580043: runtime/pprof: fix test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152580043: code review 152580043: runtime/pprof: fix test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r, dvyukov

CC:
r, dvyukov, golang-codereviews

Visibility:
Public.

Description

runtime/pprof: fix test gogo called from GC is okay for the same reasons that gogo called from System or ExternalCode is okay. All three are fake stack traces. Fixes issue 8408.

Patch Set 1 #

Patch Set 2 : diff -r 1cb654ac1d2b92857864cbad0b8304fded13233c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1cb654ac1d2b92857864cbad0b8304fded13233c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 74954520448d828bedfc86a510154919ffe8a390 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/runtime/pprof/pprof_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-15 03:21:44 UTC) #1

rsc

9 years, 6 months ago (2014-10-17 15:23:20 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=2fafe84a2de7 ***

runtime/pprof: fix test

gogo called from GC is okay
for the same reasons that
gogo called from System or ExternalCode is okay.
All three are fake stack traces.

Fixes issue 8408.

LGTM=dvyukov, r
R=r, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/152580043

Expand All Messages | Collapse All Messages