Issue 152570045: code review 152570045: cmd/gc: Add more-descriptive error message for when the...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152570045: code review 152570045: cmd/gc: Add more-descriptive error message for when the...

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by esk

Modified:
9 years, 4 months ago

Reviewers:

CC:
golang-codereviews

Visibility:
Public.

Description

cmd/gc: Add more-descriptive error message for when the programmer uses a type as an instance of itself Fixes issue 6814.

Patch Set 1 #

Patch Set 2 : diff -r 66a91d217fcb52c7011fc8103c7be748e9ab1486 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 66a91d217fcb52c7011fc8103c7be748e9ab1486 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -22 lines)			Patch
M	src/cmd/gc/typecheck.c	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	test/typecheck.go	View	1	1 chunk	+7 lines, -15 lines	0 comments	Download
A	test/typecheck.dir/foo.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/typecheck.dir/typecheck.go	View	1	1 chunk	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

esk

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-22 03:12:40 UTC) #1

gobot

9 years, 4 months ago (2014-12-19 05:14:07 UTC) #2

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/152570045 is best) in the description in your
new CL.

Thanks very much.

Expand All Messages | Collapse All Messages