Issue 152240043: code review 152240043: os: make Process.Signal 'process finished' error consis...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152240043: code review 152240043: os: make Process.Signal 'process finished' error consis... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

os: make Process.Signal 'process finished' error consistent on Unix While we're here, fix the implementation of Release on both Unix and Windows: Release is supposed to make Signal an error. While we're here, make sure we never Signal pid 0. (Don't try this at home.) Fixes issue 7658.

Patch Set 1 #

Patch Set 2 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Patch Set 3 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Patch Set 4 : diff -r 91790e0dbab46104cc226a055d30827f703d408f https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	src/os/exec_unix.go	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download
	M	src/os/exec_windows.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 6 months ago (2014-10-06 19:26:14 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=360271b2eac9 *** os: make Process.Signal 'process finished' error consistent on Unix While ...

9 years, 6 months ago (2014-10-06 19:49:23 UTC) #3

gobot

This CL appears to have broken the plan9-amd64-aram builder. See http://build.golang.org/log/c435580eb91d9c7da4a9a15dd451b7661b82d222

9 years, 6 months ago (2014-10-06 19:59:51 UTC) #4

gobot

9 years, 6 months ago (2014-10-07 06:03:54 UTC) #5

Message was sent while issue was closed.

This changed caused perf changes on windows-amd64-perf:


json-1                    old          new      delta
cputime             181250000    174687500      -3.62
time                181163358    174657482      -3.59

json-2                    old          new      delta
cputime             182812500    177656250      -2.82
time                 91882847     89420632      -2.68

json-4                    old          new      delta
time                 47087459     45871362      -2.58

json-8                    old          new      delta
cputime             195281250    190062500      -2.67
time                 25076610     24349957      -2.90

http://build.golang.org/perfdetail?commit=360271b2eac948acc949fe16bf4afe25ce9...



—gobot

Expand All Messages | Collapse All Messages