Issue 152120: code review 152120: path.TestWalk: disable error case if root

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152120: code review 152120: path.TestWalk: disable error case if root (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by rsc

Modified:
14 years, 6 months ago

Reviewers:
gri

Visibility:
Public.

Description

path.TestWalk: disable error case if root (chmod 0 doesn't cause errors for root) Fixes issue 22.

Patch Set 1 #

Patch Set 2 : code review 152120: path.TestWalk: disable error case if root #

Patch Set 3 : code review 152120: path.TestWalk: disable error case if root #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -22 lines)			Patch
	M	src/pkg/path/path_test.go	View	1 2	1 chunk	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

LGTM On 2009/11/13 08:49:14, rsc wrote: > Hello gri, > > I'd like you to ...

14 years, 6 months ago (2009-11-13 16:32:37 UTC) #2

rsc

14 years, 6 months ago (2009-11-13 19:34:35 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=27133fd21581 ***

path.TestWalk: disable error case if root
(chmod 0 doesn't cause errors for root)

Fixes issue 22.

R=gri
http://codereview.appspot.com/152120

Expand All Messages | Collapse All Messages