Issue 152070043: code review 152070043: go.net/internal/nettest: new package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152070043: code review 152070043: go.net/internal/nettest: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by mikio

Modified:
9 years, 7 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

go.net/internal/nettest: new package This CL factors out testing utilities used by both ipv4 and ipv6 packages.

Patch Set 1 : diff -r a35a4571eb78502ce9195641da205f1ea0c5e453 https://code.google.com/p/go.net #

Patch Set 2 : diff -r d53d38cb5bfc95877f424ee07c26c8b4aebb4c5a https://code.google.com/p/go.net #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -44 lines)			Patch
	M	internal/nettest/interface.go	View		2 chunks	+53 lines, -44 lines	0 comments	Download
	A	internal/nettest/stack.go	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 7 months ago (2014-10-06 21:34:32 UTC) #1

mikio

9 years, 7 months ago (2014-10-06 21:58:33 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=e55f50b7ae53&repo=net ***

go.net/internal/nettest: new package

This CL factors out testing utilities used by both ipv4 and ipv6 packages.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/152070043

Expand All Messages | Collapse All Messages