Issue 151970043: code review 151970043: fmt: fix internal unknownType function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151970043: code review 151970043: fmt: fix internal unknownType function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by r

Modified:
9 years, 6 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

fmt: fix internal unknownType function This thing should never be called, but before 151960044 it was being called, incorrectly. This is now just a precaution but let's pretend it Fixes issue 8843 even though that was fixed by 151960044. The test case was already there and ran, another mystery.

Patch Set 1 #

Patch Set 2 : diff -r 3f6f21d480eecb6df95c4e3652313daf0332788d https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/fmt/print.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-01 21:01:15 UTC) #1

9 years, 6 months ago (2014-10-01 21:35:16 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fc88ef583e21 ***

fmt: fix internal unknownType function
This thing should never be called, but before
151960044 it was being called, incorrectly.
This is now just a precaution but let's pretend it
Fixes issue 8843
even though that was fixed by 151960044.
The test case was already there and ran, another mystery.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/151970043

Expand All Messages | Collapse All Messages