Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(551)

Issue 151460043: code review 151460043: os: recomment MkdirAll (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
r, gobot
CC:
r, golang-codereviews
Visibility:
Public.

Description

os: recomment MkdirAll The internal comments are not completely precise about what is going on, and they are causing confusion. Fixes issue 8283.

Patch Set 1 #

Patch Set 2 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Patch Set 3 : diff -r c83fd77ddd770062b20c8e01b3feeda26f77e76d https://code.google.com/p/go/ #

Patch Set 4 : diff -r 360271b2eac948acc949fe16bf4afe25ce995f5a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/os/path.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2014-10-06 19:18:10 UTC) #1
r
LGTM
9 years, 5 months ago (2014-10-06 19:36:04 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=db10387ebca6 *** os: recomment MkdirAll The internal comments are not completely precise ...
9 years, 5 months ago (2014-10-06 19:49:38 UTC) #3
gobot
9 years, 5 months ago (2014-10-06 20:31:47 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/4b08c95d72c4842145d405c142af81bbef252c49
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b