Issue 151370043: code review 151370043: net/rpc: add test for issue 7689 (gob error should caus...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151370043: code review 151370043: net/rpc: add test for issue 7689 (gob error should caus... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by r

Modified:
9 years, 7 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

net/rpc: add test for issue 7689 (gob error should cause EOF) Helpfully supplied by tommi.virtanen in issue 8173.

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	src/net/rpc/client_test.go	View	1	2 chunks	+51 lines, -0 lines	0 comments	Download

Total messages: 5

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-10-03 22:02:26 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=e101bd1971be *** net/rpc: add test for issue 7689 (gob error should cause ...

9 years, 7 months ago (2014-10-07 17:52:22 UTC) #3

gobot

This CL appears to have broken the freebsd-386 builder. See http://build.golang.org/log/e5b6575ad04a7793bf1b69127c8f1ec7ec0a6c9a

9 years, 7 months ago (2014-10-07 18:01:42 UTC) #4

gobot

9 years, 7 months ago (2014-10-07 19:10:08 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/5c6282f01c0f6288997a678fe376144e1d18956e