Issue 151000043: code review 151000043: cmd/ld: don't automatically mark symbols created by -X ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151000043: code review 151000043: cmd/ld: don't automatically mark symbols created by -X ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by iant

Modified:
9 years, 7 months ago

Reviewers:
rsc

CC:
rsc, r, golang-codereviews

Visibility:
Public.

Description

cmd/ld: don't automatically mark symbols created by -X as reachable This fixes the bug in which the linker reports "missing Go type information" when a -X option refers to a symbol that is not used. Fixes issue 8821.

Patch Set 1 #

Patch Set 2 : diff -r ba0c3d698c40676f154d5bc78a109f9f4bd2277d https://code.google.com/p/go #

Patch Set 3 : diff -r e1a081e6ddf8a77b267eb0d2b9747b2181524106 https://code.google.com/p/go #

Patch Set 4 : diff -r e1a081e6ddf8a77b267eb0d2b9747b2181524106 https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	src/cmd/ld/data.c	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/cmd/ld/lib.c	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/linkx.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-09-27 18:36:04 UTC) #1

iant

On Sat, Sep 27, 2014 at 11:55 AM, <r@golang.org> wrote: > 8221 is not the ...

9 years, 7 months ago (2014-09-27 19:25:16 UTC) #3

rsc

LGTM, thanks very much Please update test/linkx_run.go to add a -X that exercises this.

9 years, 7 months ago (2014-09-28 12:45:30 UTC) #4

iant

9 years, 7 months ago (2014-09-28 15:27:12 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=9472d0e26c23 ***

cmd/ld: don't automatically mark symbols created by -X as reachable

This fixes the bug in which the linker reports "missing Go
type information" when a -X option refers to a symbol that is
not used.

Fixes issue 8821.

LGTM=rsc
R=rsc, r
CC=golang-codereviews
https://codereview.appspot.com/151000043

Expand All Messages | Collapse All Messages