Issue 150860046: code review 150860046: os: fix another case where RemoveAll should return nil

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 150860046: code review 150860046: os: fix another case where RemoveAll should return nil (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by bradfitz

Modified:
9 years, 7 months ago

Reviewers:
r, iant

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

os: fix another case where RemoveAll should return nil This hopefully fixes issue 8793. Fixes Issue 8793

Patch Set 1 #

Patch Set 2 : diff -r 35193bf04a5b64f361a1f88307188fa2d148566b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 35193bf04a5b64f361a1f88307188fa2d148566b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 35193bf04a5b64f361a1f88307188fa2d148566b https://go.googlecode.com/hg/ #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/os/path.go	View	1	1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 7 months ago (2014-09-23 20:10:15 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=49ff47443f7c *** os: fix another case where RemoveAll should return nil This ...

9 years, 7 months ago (2014-09-23 21:26:26 UTC) #3

9 years, 7 months ago (2014-09-23 21:30:50 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/150860046/diff/60001/src/os/path.go
File src/os/path.go (right):

https://codereview.appspot.com/150860046/diff/60001/src/os/path.go#newcode89
src/os/path.go:89: if IsNotExist(err) {
it's odd to see this. it's correct but i had to read the top of the function to
see why. a comment would be nice.

Expand All Messages | Collapse All Messages