Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3138)

Issue 150850043: code review 150850043: cmd/vet: fix bug where incorrect exit code was returned (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by shurcooL
Modified:
9 years, 7 months ago
Reviewers:
r
CC:
golang-codereviews, r
Visibility:
Public.

Description

cmd/vet: fix bug where incorrect exit code was returned Fixes issue 8792. This is a simple change that fixes the issue. It may be desireable to opt for a larger code change that makes this problem less likely to be inadvertedly reintroduced in the future. For instance, a vetMain() func can be used similar to gofmtMain(), or the os.Exit call can be deferred.

Patch Set 1 #

Patch Set 2 : diff -r 51cd2f4f6f2dc1277bf25fec7738669c304352ae https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 51cd2f4f6f2dc1277bf25fec7738669c304352ae https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cmd/vet/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
shurcooL
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 7 months ago (2014-09-23 02:30:11 UTC) #1
r
LGTM
9 years, 7 months ago (2014-10-02 17:32:52 UTC) #2
r
9 years, 7 months ago (2014-10-02 17:33:37 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=2b0e5133d4f3&repo=tools ***

cmd/vet: fix bug where incorrect exit code was returned

Fixes issue 8792.

This is a simple change that fixes the issue. It may be desireable
to opt for a larger code change that makes this problem less likely
to be inadvertedly reintroduced in the future. For instance, a vetMain()
func can be used similar to gofmtMain(), or the os.Exit call can be
deferred.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/150850043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b