Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2433)

Issue 150730043: code review 150730043: os: Emulate plan 9 libc in stat

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by mischief
Modified:
9 years, 4 months ago
Reviewers:
CC:
aram, ality, 0intro, golang-codereviews, rsc
Visibility:
Public.

Description

os: Emulate plan 9 libc in stat If the stat buffer is too short, the kernel informs us by putting the 2-byte size in the buffer, so we read that and try again. This follows the same algorithm as /sys/src/libc/9sys/dirfstat.c. Fixes issue 8781.

Patch Set 1 #

Patch Set 2 : diff -r 67bbd0083f7d8b423dfcac34c990d4dcedcca14f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 67bbd0083f7d8b423dfcac34c990d4dcedcca14f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 67bbd0083f7d8b423dfcac34c990d4dcedcca14f https://code.google.com/p/go/ #

Patch Set 5 : diff -r 67bbd0083f7d8b423dfcac34c990d4dcedcca14f https://code.google.com/p/go/ #

Patch Set 6 : diff -r 67bbd0083f7d8b423dfcac34c990d4dcedcca14f https://code.google.com/p/go/ #

Patch Set 7 : diff -r be3fe3a1120009c4d0b9b5d497b0c8d274177292 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M src/os/stat_plan9.go View 1 2 3 4 5 3 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 7
mischief
Hello aram@mgk.ro, ality@pbrane.org, 0intro@gmail.com (cc: golang-codereviews@googlegroups.com, rsc@golang.org), I'd like you to review this change to ...
9 years, 7 months ago (2014-09-19 22:43:08 UTC) #1
rsc
please put _ at the beginning of the new constant names. the QIDSZ is maybe ...
9 years, 7 months ago (2014-09-19 23:07:10 UTC) #2
mischief
Hello aram@mgk.ro, ality@pbrane.org, 0intro@gmail.com (cc: golang-codereviews@googlegroups.com, rsc@golang.org), Please take another look.
9 years, 7 months ago (2014-09-19 23:22:00 UTC) #3
0intro
I think you may want to move the _BIT8SZ constants to the os package.
9 years, 7 months ago (2014-09-20 07:26:21 UTC) #4
mischief
Hello aram@mgk.ro, ality@pbrane.org, 0intro@gmail.com (cc: golang-codereviews@googlegroups.com, rsc@golang.org), Please take another look.
9 years, 6 months ago (2014-10-06 05:32:02 UTC) #5
0intro
It looks good to me. Waiting for Russ for approval.
9 years, 6 months ago (2014-10-13 19:40:58 UTC) #6
gobot
9 years, 4 months ago (2014-12-19 05:13:44 UTC) #7
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/150730043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b