Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1262)

Issue 15040044: code review 15040044: go.net/ipv6: make it work with Go 1.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by mikio
Modified:
10 years, 5 months ago
Reviewers:
dave
CC:
golang-dev, dave_cheney.net
Visibility:
Public.

Description

go.net/ipv6: make it work with Go 1.1 This CL makes use of built-in syscall stuff to allow go.net/ipv6 to work together with Go 1.1. Also it's able to improve the package without churning the Go standard library. Fixes issue 6548.

Patch Set 1 : diff -r 67397a11592e https://code.google.com/p/go.net #

Patch Set 2 : diff -r 6aba239cf27b https://code.google.com/p/go.net #

Patch Set 3 : diff -r 6aba239cf27b https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -457 lines) Patch
M ipv6/control_rfc2292_unix.go View 6 chunks +21 lines, -19 lines 0 comments Download
R ipv6/control_rfc3542_linux.go View 1 chunk +0 lines, -217 lines 0 comments Download
M ipv6/control_rfc3542_unix.go View 7 chunks +31 lines, -34 lines 0 comments Download
M ipv6/icmp.go View 1 chunk +6 lines, -5 lines 0 comments Download
M ipv6/icmp_bsd.go View 1 3 chunks +5 lines, -7 lines 0 comments Download
M ipv6/icmp_linux.go View 1 3 chunks +5 lines, -7 lines 0 comments Download
M ipv6/icmp_plan9.go View 1 chunk +4 lines, -4 lines 0 comments Download
M ipv6/icmp_windows.go View 1 chunk +4 lines, -4 lines 0 comments Download
M ipv6/sockopt_rfc2292_unix.go View 3 chunks +18 lines, -11 lines 0 comments Download
M ipv6/sockopt_rfc3493_bsd.go View 1 chunk +3 lines, -2 lines 0 comments Download
M ipv6/sockopt_rfc3493_linux.go View 1 chunk +3 lines, -2 lines 0 comments Download
M ipv6/sockopt_rfc3493_unix.go View 2 chunks +43 lines, -33 lines 0 comments Download
M ipv6/sockopt_rfc3493_windows.go View 6 chunks +16 lines, -16 lines 0 comments Download
R ipv6/sockopt_rfc3542_bsd.go View 1 chunk +0 lines, -44 lines 0 comments Download
R ipv6/sockopt_rfc3542_linux.go View 1 chunk +0 lines, -42 lines 0 comments Download
M ipv6/sockopt_rfc3542_unix.go View 1 chunk +52 lines, -10 lines 0 comments Download

Messages

Total messages: 8
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
10 years, 6 months ago (2013-10-18 19:26:33 UTC) #1
mikio
ping if this approach looks fine, i will split this CL into two.
10 years, 5 months ago (2013-11-02 09:14:56 UTC) #2
dave_cheney.net
On 2013/11/02 09:14:56, mikio wrote: > ping > > if this approach looks fine, i ...
10 years, 5 months ago (2013-11-02 23:29:02 UTC) #3
mikio
ping
10 years, 5 months ago (2013-11-05 01:09:59 UTC) #4
dave_cheney.net
On 2013/11/05 01:09:59, mikio wrote: > ping I haven't reviewed the CL yet , but ...
10 years, 5 months ago (2013-11-06 02:12:37 UTC) #5
dave_cheney.net
On 2013/11/06 02:12:37, dfc wrote: > On 2013/11/05 01:09:59, mikio wrote: > > ping > ...
10 years, 5 months ago (2013-11-06 09:52:41 UTC) #6
mikio
On Wed, Nov 6, 2013 at 6:52 PM, <dave@cheney.net> wrote: > Let's hope we don't ...
10 years, 5 months ago (2013-11-06 12:33:08 UTC) #7
mikio
10 years, 5 months ago (2013-11-06 12:33:59 UTC) #8
*** Submitted as
https://code.google.com/p/go/source/detail?r=75017ecb835f&repo=net ***

go.net/ipv6: make it work with Go 1.1

This CL makes use of built-in syscall stuff to allow go.net/ipv6
to work together with Go 1.1. Also it's able to improve the package
without churning the Go standard library.

Fixes issue 6548.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/15040044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b